Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tabular output for unrecognized errors #1745

Conversation

sponomarev
Copy link

@sponomarev sponomarev commented Jan 6, 2020

"table" package is strict about data and fails on inconsistent rows dimension.

For that kind of composition error

[
  {
    message: 'Field "Mutation.createSomething" can only be defined once.'
  }
]

service:check ends up with an exception

Error: Table must have a consistent number of cells.
    at validateTableData (~/Projects/sandbox/node_modules/table/dist/validateTableData.js:47:15)
    at Object.table (~/Projects/sandbox/node_modules/table/dist/table.js:96:34)
    at ServiceCheck.run (~/Projects/sandbox/node_modules/apollo/lib/commands/service/check.js:326:30)
  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla
Copy link

@sponomarev: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

"table" package is strict about data and fails on inconsistent rows dimension
@sponomarev sponomarev force-pushed the fix/service-check-errors-formatting branch from 6ac5529 to f275ec2 Compare January 6, 2020 12:12
@sponomarev
Copy link
Author

Closed in favor of #1806

@sponomarev sponomarev closed this Apr 3, 2020
@sponomarev sponomarev deleted the fix/service-check-errors-formatting branch April 3, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants