Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of unformatted errors in composition #1806

Merged
merged 3 commits into from
Feb 21, 2020

Conversation

JakeDawkins
Copy link
Contributor

@JakeDawkins JakeDawkins commented Feb 20, 2020

Right now, apollo service:check for federated services expects a specifically shaped error message from composition errors, but not all errors are the expected shape. When that happens, we are not formatting the errors properly for display, and users are seeing a cryptic error about an inconsistent number of cells in the display table. This PR aims to fix that by displaying unformatted (unexpected) errors separately from the ones we can recognize and format.

before:

Screen Shot 2020-02-20 at 11 49 35 AM

after:

Screen Shot 2020-02-20 at 11 49 11 AM

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins JakeDawkins merged commit 5f8c98b into master Feb 21, 2020
@JakeDawkins JakeDawkins deleted the jake/fix-composition-errors-table branch February 21, 2020 15:24
@sponomarev
Copy link

sponomarev commented Apr 3, 2020

@JakeDawkins The same problem has been addressed in #1745 earlier and was ignored 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants