Fix display of unformatted errors in composition #1806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
apollo service:check
for federated services expects a specifically shaped error message from composition errors, but not all errors are the expected shape. When that happens, we are not formatting the errors properly for display, and users are seeing a cryptic error about an inconsistent number of cells in the display table. This PR aims to fix that by displaying unformatted (unexpected) errors separately from the ones we can recognize and format.before:
after:
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.