Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to define schema download output path that doesn't exist yet #1807

Merged
merged 3 commits into from
Feb 21, 2020

Conversation

JakeDawkins
Copy link
Contributor

resolves #1788

Previously, the CLI couldn't download schemas in apollo service:download or apollo client:download-schema when the path in the OUTPUT didn't exist.

This PR aims to add the ability to create a path given in the OUTPUT and to save the outputted schema to that path :)

Screen Shot 2020-02-21 at 10 14 58 AM

Screen Shot 2020-02-21 at 10 16 24 AM

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins JakeDawkins merged commit afd3c8e into master Feb 21, 2020
@JakeDawkins JakeDawkins deleted the jake/download-path-fix branch February 21, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apollo client:download fails if OUTPUT doesn't exist
1 participant