Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "no service found to link..." error #1847

Merged
merged 3 commits into from
Mar 25, 2020

Conversation

zionts
Copy link
Contributor

@zionts zionts commented Mar 25, 2020

This updates the error message that occurs when a config.service.name is
required in order to execute a command. Before this commit, there were
two distinct messages that were used in commands to communicate this
error to the user, which were slightly different in their wording. This
updates the wording to provide an explanation as well as next steps on
how to remedy the issue. Additionally, it uses the CLIError class in
order to print out an error in a "friendly" way without a stack trace,
as recommended by the @oclif/errors package we are using: https://oclif.io/docs/commands#thiserrormessage-string--error-options-code-string-exit-number

For changelog entry, please see #1849

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@zionts
Copy link
Contributor Author

zionts commented Mar 25, 2020

Before:
image

After:
image

This updates the error message that occurs when a config.service.name is
required in order to execute a command. Before this commit, there were
two distinct messages that were used in commands to communicate this
error to the user, which were slightly different in their wording. This
updates the wording to provide an explanation as well as next steps on
how to remedy the issue. Additionally, it uses the `CLIError` class in
order to print out an error in a "friendly" way without a stack trace,
as recommended by the @oclif/errors package we are using: https://oclif.io/docs/commands#thiserrormessage-string--error-options-code-string-exit-number
@zionts zionts force-pushed the adam/20/3/no-graph-found-error branch from dbcd274 to a65872f Compare March 25, 2020 03:05
@zionts
Copy link
Contributor Author

zionts commented Mar 25, 2020

Update -- Added a commit (that we can revert if we'd like) that makes the error message split with newlines instead of spaces. This makes it more likely to fit in your shell:
image

@zionts zionts requested a review from JakeDawkins March 25, 2020 03:09
Co-Authored-By: Jake Dawkins <dawkinsjh@gmail.com>
@JakeDawkins JakeDawkins merged commit 227a3e7 into master Mar 25, 2020
@JakeDawkins JakeDawkins deleted the adam/20/3/no-graph-found-error branch March 30, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants