Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "no service found to link..." error #1847

Merged
merged 3 commits into from
Mar 25, 2020
Merged

Update "no service found to link..." error #1847

merged 3 commits into from
Mar 25, 2020

Commits on Mar 25, 2020

  1. Update "no service found to link..." error 

    This updates the error message that occurs when a config.service.name is
required in order to execute a command. Before this commit, there were
two distinct messages that were used in commands to communicate this
error to the user, which were slightly different in their wording. This
updates the wording to provide an explanation as well as next steps on
how to remedy the issue. Additionally, it uses the `CLIError` class in
order to print out an error in a "friendly" way without a stack trace,
as recommended by the @oclif/errors package we are using: https://oclif.io/docs/commands#thiserrormessage-string--error-options-code-string-exit-number
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    a65872f View commit details
    Browse the repository at this point in the history

  2. Remove unused imports

    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    f09a070 View commit details
    Browse the repository at this point in the history

  3. Update packages/apollo/src/utils/errors.ts 

    Co-Authored-By: Jake Dawkins <dawkinsjh@gmail.com>
    @zionts @JakeDawkins
    zionts and JakeDawkins committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    aed6a1d View commit details
    Browse the repository at this point in the history