-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass directives from schema modules through buildServiceDefinition #715
Conversation
@tgerk: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Thanks for looking into this! I don't think this is the right solution though, because directives live in their own namespace, and adding them to I think the solution is to keep a separate list of Also, it seems this PR needs to be rebased, because it includes unrelated commits made by others. |
prevents name-collision with types
Pardon the confusion, I have rebased my branch from the tagged release to master branch. I've also segregated the directives from types as you pointed out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from my single comment, this LGTM. Would like @martijnwalraven to give final pass and approval.
Changes have been made to variable names and to behavior as suggested, including tests.
|
Thanks for opening this PR and making the changes! (The CI failures are unrelated I think.) |
Directive definitions were discarded when merging types from modules in
buildServiceSchema
. The fix is nearly trivial, becauseKind.DIRECTIVE_DEFINITION
is a unique case that is neither a schema definition nor a type definition.