Add event-stream as a dep and lock it (security issue) #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As identified in dominictarr/event-stream#116, `event-stream` has a major security issue (malware injection) in version 3.3.6 (thanks to `flatmap-stream` version 0.1.1). `event-stream` 3.3.6 is referenced as a child dep in this project, through `tsc-watch` and `vscode-apollo` / `vscode`. This commit adds `event-stream` as a top level dependency, and locks it to the most recent version that excludes `flatmap-stream` (version 3.3.4). This should work for now, but ultimately `tsc-watch` and `vscode` should be updated to newer versions, that address this issue (since their child deps are the problem). Both projects have yet to submit fixes to this problem.
abernix
approved these changes
Nov 26, 2018
abernix
added a commit
that referenced
this pull request
Nov 27, 2018
This reverts commit df384df, which should no longer be necessary to be pinned at this level due to forthcoming updates (in the next commit) which update the `package-lock.json` coupled with transitive updates to `vscode` (which contained the `event-stream` itself).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified in dominictarr/event-stream#116,
event-streamhas a major security issue (malware injection) in version 3.3.6 (thanks toflatmap-streamversion 0.1.1).event-stream3.3.6 is referenced as a child dep in this project, throughtsc-watchandvscode-apollo/vscode.This commit adds
event-streamas a top level dependency, and locks it to the most recent version that excludesflatmap-stream(version 3.3.4).This should work for now, but ultimately
tsc-watchandvscodeshould be updated to newer versions, that address this issue (since their child deps are the problem). Both projects have yet to submit fixes to this problem.