[build] migrate to Gradle #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
requested review from
sachindshinde,
martinbonnin and
BoD
as code owners
Explicitly checking for SNAPSHOT version as extra properties are not available at java task configuration time.
martinbonnin
approved these changes
May 26, 2022
| version = 2.0.2-SNAPSHOT | ||
|
|
||
| # See https://github.com/gradle/gradle/issues/11308 | ||
| systemProp.org.gradle.internal.publish.checksums.insecure=true |
There was a problem hiding this comment.
I think you can skip this. Sonatype now handles this correctly
theJC
pushed a commit
to theJC/federation-jvm
that referenced
this pull request
Jul 15, 2022
* [build] migrate to Gradle Resolves apollographql#131 * generate sources/javadocs only for releases * conditionally build sources and javadocs Explicitly checking for SNAPSHOT version as extra properties are not available at java task configuration time. Co-authored-by: Dariusz Kuc <dkuc@apollographql.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #131