Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish changelog notes under GH Releases #636

Closed
setchy opened this issue Apr 2, 2021 · 11 comments
Closed

Publish changelog notes under GH Releases #636

setchy opened this issue Apr 2, 2021 · 11 comments

Comments

@setchy
Copy link
Contributor

setchy commented Apr 2, 2021

Would it be possible to begin publishing release notes for the federation packages?

This would make it easier for consumers to understand what are the non-breaking updates, and more importantly any potential breaking changes

@trevor-scheer
Copy link
Member

Hey @setchy, there are CHANGELOG.mds within the federation and gateway subfolders where you can view these changes. Is the ask that these changes be published more formally via GH releases? I think this could be nice to implement.

@setchy
Copy link
Contributor Author

setchy commented Apr 2, 2021

Thanks @trevor-scheer - I'll pin that file.

That's correct - publishing them in the GH Releases is the feature request. For context, we use renovate-bot to automate dependency updates and it pulls release notes from GH and attaches them to our PRs.

@setchy setchy changed the title Release notes Publish changelog notes under GH Releases Apr 2, 2021
@glasser
Copy link
Member

glasser commented Apr 2, 2021

Renovate does support CHANGELOG files, so we might just have some misconfiguration there. See renovatebot/renovate#4724

@glasser
Copy link
Member

glasser commented Apr 2, 2021

@glasser
Copy link
Member

glasser commented Apr 2, 2021

(We definitely have it set up properly for apollo-server, as you can see in the release notes section of #623)

@setchy
Copy link
Contributor Author

setchy commented Apr 2, 2021

Thanks @glasser. I can confirm that renovate is correctly pulling the PR change notes for apollo-server

@setchy
Copy link
Contributor Author

setchy commented Apr 6, 2021

I believe renovate is looking for the CHANGELOG.md at the root of https://github.com/apollographql/federation, which is why https://github.com/apollographql/apollo-server is working

For reference: renovate github changelog worker

@setchy
Copy link
Contributor Author

setchy commented Jun 12, 2021

Example of the most recent Renovate PR showing the difference between @apollo/gateway and apollographql/apollo-server

Screen Shot 2021-06-12 at 08 52 31

@setchy
Copy link
Contributor Author

setchy commented Sep 25, 2021

For those interesting: I believe Renovate issue renovatebot/renovate#10954 could be root of the inconsistent release note parsing with this repo

@setchy
Copy link
Contributor Author

setchy commented Dec 2, 2021

Monorepo handling now available with Renovate v29.30.0 - renovatebot/renovate#12543

However these two issues will prevent use of this enhancement

That said, going to close this issue

@setchy
Copy link
Contributor Author

setchy commented May 2, 2022

#1815 was recently raised to reexamine setting this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants