-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 17 support #1541
Node 17 support #1541
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
So the changes clearly looks good. And I don't have personal opinions about this. But I believe our current and historical policy has been to only "support" LTS versions of nodes (even numbered) and let user pass I'll simply point out that this means we'll run more CI on every PR after this. I have no clue if we care (and of course, we could also allow 17 in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objection, but please hook it up to the other requires
in the CircleCI workflows
section (can't comment on it in the PR because it's out of range). (Search for "JS: Node 16", look for oss/dry_run
and oss/lerna_tarballs
sections.
The things said above about historical policy are true. Odd versions of Node.js used to be much less stable than they are these days. That's changed to some degree, though. Our general pattern has been to only be testing 3 even-numbered (LTS) versions at a time. This puts us over that, but only for a couple months until May 1 when we probably will want to: add 18, drop 17 (because it immediately goes to unsupported) and also drop v12 (which will reach EOL) |
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
* Node 17 support Co-authored-by: Chris Lenfest <clenfest@apollographql.com>
Node 17 declared compatible in all
package.json
and added in CI.