Create stargate Dockerfile and GH Publish action #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a Dockerfile for building a stargate image. Currently this is building from an in-flight PR (#135), which we can update as soon as it lands on `main`. The additional GH action publishes the container to the new GitHub Container Registry. For now, this requires a PAT (as noted in the comments). We should remove this in favor of GITHUB_TOKEN as soon as it's supported.
abernix
reviewed
Sep 29, 2020
Co-authored-by: Jesse Rosenberger <git@jro.cc>
abernix
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
This won't work anymore if (once?) #186 is merged to #135
Do you want to base this on #186 and assume stargate-actix-web will be the one we use?
While true, that makes #186 a blocker of this PR unnecessarily.
Instead, let's have #186 make the appropriate change — when finished/ratified — to this file so this can merge right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a Dockerfile for building a stargate image.
Currently this is building from an in-flight PR (#135), which we
can update as soon as it lands on
main.The additional GH action publishes the container to the new
GitHub Container Registry. For now, this requires a PAT (as noted
in the comments). We should remove this in favor of GITHUB_TOKEN
as soon as it's supported.