Fix losing defer info when cloning fetch groups #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
4 tasks
clenfest
approved these changes
Sep 6, 2022
added 2 commits
September 6, 2022 09:47
When `@defer` was added, the method cloning `FetchGroup` was mistakenly not updated to preserve the related information. This means that in case where the query planner had to consider multiple options for a plan, the some deferred fetch may end up losing their defer information. Fixes apollographql#2128
pcmanus
force-pushed
the
typename-and-defer
branch
from
6466925
to
2ff0aa2
Compare
abernix
added a commit
to apollographql/router
that referenced
this pull request
Sep 6, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
@deferwas added, the method cloningFetchGroupwas mistakenlynot updated to preserve the related information. This means that in
case where the query planner had to consider multiple options for a
plan, the some deferred fetch may end up losing their defer information.
Fixes #2128