fixed a regression created by PR #2967 #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
duckki
force-pushed
the
duckki/fix-pr-2961-regression
branch
from
07724a3
to
3d33a11
Compare
dariuszkuc
reviewed
Apr 16, 2024
| const queryPlan = qp.buildQueryPlan(op); | ||
| const fetch_nodes = findFetchNodes(subgraph1.name, queryPlan.node); | ||
| expect(fetch_nodes).toHaveLength(1); | ||
| // Note: The query is expected to carry the `@operation` directive. |
There was a problem hiding this comment.
i think that's an old comment from previous test?
There was a problem hiding this comment.
Oh, you are right. Let me clean it up.
duckki
force-pushed
the
duckki/fix-pr-2961-regression
branch
from
3d33a11
to
74b0226
Compare
dariuszkuc
approved these changes
Apr 16, 2024
|
Thanks @dariuszkuc! I'll work with security on the semgrep failures. |
duckki
force-pushed
the
duckki/fix-pr-2961-regression
branch
from
a35b079
to
6d4be86
Compare
- Previously, directives applied on operations weren't properly attached to their parent elements. - Changed the `Operation` class to inherit from `DirectiveTargetElement` class, which attaches directives properly. Related: apollographql#2961
- cleaned up the comment in the test
duckki
force-pushed
the
duckki/fix-pr-2961-regression
branch
from
6d4be86
to
58c1161
Compare
|
I'm gonna add a changeset entry with So we can kick off a new release |
o0Ignition0o
added a commit
that referenced
this pull request
Apr 17, 2024
dariuszkuc
pushed a commit
that referenced
this pull request
Apr 17, 2024
o0Ignition0o
pushed a commit
that referenced
this pull request
Apr 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/composition@2.7.4 ### Patch Changes - Updated dependencies \[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0)]: - @apollo/federation-internals@2.7.4 - @apollo/query-graphs@2.7.4 ## @apollo/gateway@2.7.4 ### Patch Changes - Updated dependencies \[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0), [`c89d8287e88d12cfd34c1baf1f42db672731b8a7`](c89d828)]: - @apollo/query-planner@2.7.4 - @apollo/federation-internals@2.7.4 - @apollo/composition@2.7.4 ## @apollo/federation-internals@2.7.4 ### Patch Changes - Fixed a regression created by PR (#2967), where directives would not be properly attached to their parent. (#2982) ([#2984](#2984)) ## @apollo/query-graphs@2.7.4 ### Patch Changes - Updated dependencies \[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0)]: - @apollo/federation-internals@2.7.4 ## @apollo/query-planner@2.7.4 ### Patch Changes - Fixed a regression created by PR (#2967), where directives would not be properly attached to their parent. (#2982) ([#2984](#2984)) - Ensure query variables used in the directives applied at the operation level are retained in subgraph queries (#2986) ([#2986](#2986)) - Updated dependencies \[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0)]: - @apollo/federation-internals@2.7.4 - @apollo/query-graphs@2.7.4 ## @apollo/subgraph@2.7.4 ### Patch Changes - Updated dependencies \[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0)]: - @apollo/federation-internals@2.7.4 ## apollo-federation-integration-testsuite@2.7.4 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operationclass to inherit fromDirectiveTargetElementclass, which attaches directives properly.Related: #2961