Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure query variables used in the directives applied at the operation level are retained in subgraph queries #2986

Merged
merged 3 commits into from Apr 19, 2024

Conversation

duckki
Copy link
Contributor

@duckki duckki commented Apr 19, 2024

This fixes another regression created by PR #2967.

Related: #2961

- Ensure query variables used in the directives applied at the operation level are retained in subgraph queries
@duckki duckki self-assigned this Apr 19, 2024
@duckki duckki requested a review from a team as a code owner April 19, 2024 17:46
Copy link

netlify bot commented Apr 19, 2024

👷 Deploy request for apollo-federation-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 77d2cf7

Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: 77d2cf7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@apollo/query-planner Patch
@apollo/gateway Patch
@apollo/federation-internals Patch
@apollo/composition Patch
@apollo/query-graphs Patch
@apollo/subgraph Patch
apollo-federation-integration-testsuite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Apr 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dariuszkuc dariuszkuc merged commit c89d828 into apollographql:main Apr 19, 2024
15 checks passed
o0Ignition0o pushed a commit that referenced this pull request Apr 22, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @apollo/composition@2.7.4

### Patch Changes

- Updated dependencies
\[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0)]:
    -   @apollo/federation-internals@2.7.4
    -   @apollo/query-graphs@2.7.4

## @apollo/gateway@2.7.4

### Patch Changes

- Updated dependencies
\[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0),
[`c89d8287e88d12cfd34c1baf1f42db672731b8a7`](c89d828)]:
    -   @apollo/query-planner@2.7.4
    -   @apollo/federation-internals@2.7.4
    -   @apollo/composition@2.7.4

## @apollo/federation-internals@2.7.4

### Patch Changes

- Fixed a regression created by PR (#2967), where directives would not
be properly attached to their parent. (#2982)
([#2984](#2984))

## @apollo/query-graphs@2.7.4

### Patch Changes

- Updated dependencies
\[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0)]:
    -   @apollo/federation-internals@2.7.4

## @apollo/query-planner@2.7.4

### Patch Changes

- Fixed a regression created by PR (#2967), where directives would not
be properly attached to their parent. (#2982)
([#2984](#2984))

- Ensure query variables used in the directives applied at the operation
level are retained in subgraph queries (#2986)
([#2986](#2986))

- Updated dependencies
\[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0)]:
    -   @apollo/federation-internals@2.7.4
    -   @apollo/query-graphs@2.7.4

## @apollo/subgraph@2.7.4

### Patch Changes

- Updated dependencies
\[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0)]:
    -   @apollo/federation-internals@2.7.4

## apollo-federation-integration-testsuite@2.7.4

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants