fix(federation): Print @tag and @inaccessible directives conditionally #859
Conversation
| /** | ||
| * A set of directive names that have been used at least once | ||
| */ | ||
| type AppliedDirectiveUsages = Set<string>; |
There was a problem hiding this comment.
This is not a blocker, but the term 'applied directive usages' is a bit weird because both 'applied directives' and 'directive usages' are meant to differentiate between directive definitions and their use.
| @@ -21,7 +21,7 @@ import { | |||
| DirectiveNode, | |||
| } from 'graphql'; | |||
| import { transformSchema } from 'apollo-graphql'; | |||
| import apolloTypeSystemDirectives from '../directives'; | |||
| import apolloTypeSystemDirectives, { appliedDirectives, federationDirectives } from '../directives'; | |||
There was a problem hiding this comment.
I had missed this before, but appliedDirectives doesn't seem like the right name here, because these exports are directive definitions (as opposed to directive applications, which is what we find on AST nodes). Maybe something like otherKnownDirectives could work here?
|
Noting the recommendations are strictly naming/internally facing related and I'm hoping to get in on a Rover release, I'm going to merge now and follow up with naming fixes today. |
trevor-scheer
deleted the
trevor/print-tag-inaccessible-directives-conditionally
branch
|
@trevor-scheer agree with your decision to expedite and follow-up with the suggestions that @martijnwalraven offered. thanks! |
Only print the directive definitions and
@coredeclarations for the@tagand@inaccessibledirectives in the supergraph SDL if there are usages of them found in the subgraph schemas.