Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query batching for single queries for hapi integration. #123

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Fix query batching for single queries for hapi integration. #123

merged 1 commit into from
Sep 2, 2016

Conversation

dahjelle
Copy link
Contributor

@dahjelle dahjelle commented Sep 2, 2016 •
edited

The hapi integration didn't correctly check to see if a query was batched or not.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@dahjelle dahjelle mentioned this pull request Sep 2, 2016
Closed
@helfer
Copy link
Contributor

helfer commented Sep 2, 2016

Thanks!

@helfer helfer merged commit 64cd806 into apollographql:master Sep 2, 2016
@dahjelle
Copy link
Contributor Author

dahjelle commented Sep 6, 2016

Any ETA for getting this published? I completely understand if you are waiting for other changes—just helps me know if I should temporarily deploy from master or if a new NPM package is coming out soon. Thanks for all your work! :-D

helfer added a commit that referenced this pull request Sep 6, 2016
@helfer
Revert "Fix query batching for single queries for hapi integration. (#…
7b42c33 
…123)"

This reverts commit 64cd806.
@nnance
Copy link
Contributor

nnance commented Sep 6, 2016

@helfer @dahjelle I am actively refactoring the HAPI integration. I will make sure to resolved this issue in my new version and will reference this issue in my PR for review. ETA tomorrow 9/7

@nnance nnance mentioned this pull request Sep 8, 2016
Merged
4 tasks
@nnance
Copy link
Contributor

nnance commented Sep 8, 2016

@dahjelle I have opened the PR and welcome your feedback. #127

@nnance nnance added this to the 0.3 milestone Sep 9, 2016
@nnance nnance self-assigned this Sep 9, 2016
martijnwalraven pushed a commit that referenced this pull request Oct 17, 2017
Merge pull request #123 from apollographql/add-default-field-resolver
9843891 
Update apollo-server docs
trevor-scheer pushed a commit that referenced this pull request May 6, 2020
@renovate
chore(deps): update dependency @apollo/gateway to ^0.5.0 (#123)
a90b5e7
trevor-scheer pushed a commit that referenced this pull request May 14, 2020
@renovate
chore(deps): update dependency @apollo/gateway to ^0.5.0 (#123)
b51595a
@trevor-scheer trevor-scheer mentioned this pull request Oct 17, 2022
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@nnance nnance

Labels
None yet
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dahjelle @helfer @nnance