Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resolver fn to be async #220

Merged

Conversation

maclockard
Copy link

Looking at some possible downstream consumers, these seems fine and not breaking since they can receive an async subscription function:

fixes #213

@XavierLeTohic
Copy link

Any news on this?

@AadamZ5
Copy link

AadamZ5 commented Jul 21, 2020

@hwillson Can you please glance at this? You're the most recent active contributor of this project. This changes similar files from a PR you've recently merged #229.

Many dependent libraries would benefit from this contribution. Currently, many developers have to employ ugly workarounds to get around this limitation. The lack of async operability is frankly extremely inconvenient in a handful of scenarios.

@hwillson hwillson added this to the Release 3.0 milestone Nov 25, 2021
@hwillson hwillson changed the base branch from master to release-3.0 November 25, 2021 18:27
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long @maclockard - we'll aim to have this out in 3.0 (which will be released soon). Thanks!

@hwillson hwillson merged commit 94a9993 into apollographql:release-3.0 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support async topics
4 participants