Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all the dependencies #272

Closed
wants to merge 4 commits into from

Conversation

abdonrd
Copy link
Contributor

@abdonrd abdonrd commented Oct 15, 2019

Update all the dependencies to the latest versions.

@abdonrd abdonrd force-pushed the update-dependencies branch 5 times, most recently from 48b757e to 7818b80 Compare October 15, 2019 06:21
@abdonrd
Copy link
Contributor Author

abdonrd commented Oct 17, 2019

Friendly ping to @jnwng 😄

@jnwng
Copy link
Contributor

jnwng commented Oct 24, 2019

looks good to me! one last thing i need to validate is the yarn.lock changes — as much as i trust you, i actually realize i have no way to validate security vulnerabilities that might have been introduced

@abdonrd
Copy link
Contributor Author

abdonrd commented Oct 24, 2019

Ok! I just run rm -rf node_modules yarn.lock; yarn install

@abdonrd
Copy link
Contributor Author

abdonrd commented Oct 29, 2019

Anything else, @jnwng? Thanks in advance!

@abdonrd
Copy link
Contributor Author

abdonrd commented Oct 12, 2020

Hi @jnwng! What happened to this PR? Thanks in advance!

PowerKiKi added a commit to PowerKiKi/graphql-tag that referenced this pull request Nov 6, 2020
This upgrade all dev dependencies in order to implement ES6 exports
in order to solve apollographql#303.

This also remove yarn.lock entirely because this package is meant to
work with npm only as can be seen from the mention of npm command in
package.json.

Fixes apollographql#303
Closes apollographql#272
Closes apollographql#273
@PowerKiKi
Copy link
Contributor

Ideally, this should be closed in favor of #325.

benjamn pushed a commit to PowerKiKi/graphql-tag that referenced this pull request Jan 29, 2021
This upgrade all dev dependencies in order to implement ES6 exports
in order to solve apollographql#303.

This also remove yarn.lock entirely because this package is meant to
work with npm only as can be seen from the mention of npm command in
package.json.

Fixes apollographql#303
Closes apollographql#272
Closes apollographql#273
@benjamn benjamn closed this in #325 Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants