Re-export all public graphql-tag exports
#5861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwillson
force-pushed
the
graphql-tag-tweaks
branch
from
b870205
to
c78ff36
Compare
Make sure we're re-exporting all public `graphql-tag` exports, while ensuring that valid types exist.
Based on how we're importing and re-exporting `graphql-tag`, we no longer need to leverage Rollup's commonjs plugin `namedExports` feature. Since we're also not building an ESM bundle via Rollup, we don't need to use the commonjs plugin for anything else, so it can be removed.
hwillson
force-pushed
the
graphql-tag-tweaks
branch
from
c78ff36
to
33e83ed
Compare
|
@hwillson related to this, I have send a PR to update all the But the repository seems a bit abandoned. Do you think you could check it out? It would be great to later be able to export the library as ES Modules. I would like to be able to use |
benjamn
reviewed
Jan 28, 2020
| // then re-exporting them separately, helps keeps bundlers happy without any | ||
| // additional config changes. | ||
| import gql from 'graphql-tag'; | ||
| const { |
There was a problem hiding this comment.
You can actually just do export const { ... } = gql here, to avoid repetition.
| // be fully updated to use Typescript, and these discrepancies will be fixed. | ||
|
|
||
| declare module 'graphql-tag' { | ||
| function gql(literals: any, ...placeholders: any[]): any; |
There was a problem hiding this comment.
Shouldn't this be literals: string[]?
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we're re-exporting all public
graphql-tagexports, while ensuring that valid types exist.