Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supergraph-demo smoke test 7 fails on router 0.16 #1584

Closed
Tracked by #80
Geal opened this issue Aug 23, 2022 · 4 comments · Fixed by #1650
Closed
Tracked by #80

supergraph-demo smoke test 7 fails on router 0.16 #1584

Geal opened this issue Aug 23, 2022 · 4 comments · Fixed by #1650
Assignees
@Geal
Labels
component/defer

Comments

@Geal
Copy link
Contributor

Geal commented Aug 23, 2022

https://github.com/apollographql/supergraph-demo-fed2/pull/212/checks#step:10:165
@Geal
Copy link
Contributor Author

Geal commented Aug 23, 2022

a bisect points to fa0323e

@Geal
Copy link
Contributor Author

Geal commented Aug 26, 2022

related to apollographql/federation#2093

@pcmanus
Copy link
Contributor

pcmanus commented Aug 29, 2022

Just to update that the fix for this just got committed and will be part of federation 2.1.0 which should be published later today or tomorrow.

But @Geal, calling your attention on the fact that this PR also changes the name of the config passed to the query planner (from deferStreamSupport: { enableDefer: true }} to incrementalDelivery: { enabledDefer: true }}), so this will have to be updated in the router at the same time than the new dependency is incorporated.

abernix added a commit to apollographql/federation-rs that referenced this issue Aug 30, 2022
@abernix
Update deferStreamSupport to incrementalDelivery
330cb2c 
Ref: apollographql/router#1584 (comment)
abernix added a commit to apollographql/federation-rs that referenced this issue Aug 30, 2022
@abernix
Update deferStreamSupport to incrementalDelivery
a264ab2 
...And Rust structs to match.

Ref: apollographql/router#1584 (comment)
@abernix
Copy link
Member

abernix commented Aug 30, 2022

This should be fixed with the router-bridge update that is coming soon: apollographql/federation-rs#161

@abernix abernix added this to the v1.0.0-alpha.1 milestone Aug 30, 2022
@Geal Geal mentioned this issue Aug 30, 2022
Merged
@Geal Geal closed this as completed in d0cab77 Aug 30, 2022
Geal added a commit that referenced this issue Aug 31, 2022
@Geal @abernix
update router-bridge (#1650)
b3436b8 
Fix #1546 
Fix #1584 
Fix #1633

Co-authored-by: Jesse Rosenberger <git@jro.cc>
@abernix abernix mentioned this issue Sep 2, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geal Geal

Labels
component/defer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update router-bridge apollographql/router
3 participants
@Geal @pcmanus @abernix