Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit: Remove unused pub function Request::from_bytes() #1855

Closed
abernix opened this issue Sep 21, 2022 · 1 comment · Fixed by #1858
Closed

nit: Remove unused pub function Request::from_bytes() #1855

abernix opened this issue Sep 21, 2022 · 1 comment · Fixed by #1858
Assignees
@abernix

Comments

@abernix
Copy link
Member

abernix commented Sep 21, 2022

We discovered this Request::from_bytes() method while we were documenting the API. It currently does not have a test and it was no longer used as of d147f97d in #429.

We'll be happy to add this back with a use-case but for now this seems like a worthwhile breaking change as part of a last cleanup of the API.
@abernix abernix self-assigned this Sep 21, 2022
@abernix abernix added this to the v1.0.0 milestone Sep 21, 2022
@abernix
Copy link
Member Author

abernix commented Sep 21, 2022

Let's do this after #1850 (where I discovered this) to avoid the merge conflict.

abernix added a commit that referenced this issue Sep 21, 2022
@abernix
Removed Request::from_bytes() from public API
cf98ec7 
This removes `Request::from_bytes()` from the public API.  We were no
longer using it and we don't expect anyone external to have been relying on
it.

This was discovered this function during an exercise of documenting our
entire public API.  We considered keeping it briefly, but it doesn't
necessarily meet our requirements for shipping it in the public API.  It's
internal usage was removed in
[`d147f97d`](d147f97d as part
of [PR #429](#429).

We can consider re-introducing this in the future (it even has a matching
`Response::from_bytes()` which it composes against nicely!), but it seemed
worth remove it for the time-being until the use-cases are here.  (We can
already see the use-cases, but we want to actually design them first.)

Closes #1855
@abernix abernix mentioned this issue Sep 21, 2022
Merged
abernix added a commit that referenced this issue Sep 21, 2022
@abernix
Removed Request::from_bytes() from public API
1372124 
This removes `Request::from_bytes()` from the public API.  We were no
longer using it and we don't expect anyone external to have been relying on
it.

This was discovered this function during an exercise of documenting our
entire public API.  We considered keeping it briefly, but it doesn't
necessarily meet our requirements for shipping it in the public API.  It's
internal usage was removed in
[`d147f97d`](d147f97d) as part
of [PR #429](#429).

We can consider re-introducing this in the future (it even has a matching
`Response::from_bytes()` which it composes against nicely!), but it seemed
worth remove it for the time-being until the use-cases are here.  (We can
already see the use-cases, but we want to actually design them first.)

Closes #1855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abernix abernix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed Request::from_bytes() from public API apollographql/router
1 participant
@abernix