Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running router with APOLLO_TELEMETRY_DISABLED=1 fails #2478

Open
Meemaw opened this issue Jan 26, 2023 · 3 comments
Open

Running router with APOLLO_TELEMETRY_DISABLED=1 fails #2478

Meemaw opened this issue Jan 26, 2023 · 3 comments
Labels
raised by user

Comments

@Meemaw
Copy link
Contributor

Meemaw commented Jan 26, 2023

Describe the bug
Running router v1.9.0 with APOLLO_TELEMETRY_DISABLED=1 (as per the documentation), fails with the following error:

error: one of the values isn't valid for an argument
@bnjjj bnjjj self-assigned this Jan 26, 2023
@bnjjj
Copy link
Contributor

bnjjj commented Jan 26, 2023

It needs to be used with true or false instead of 1 or 0. I will update the documentation

@bnjjj bnjjj mentioned this issue Jan 26, 2023
Merged
@abernix
Copy link
Member

abernix commented Jan 27, 2023

@bnjjj Let's land the documentation fix for now, but can we change the implementation to support 1 and 0? It's critical that we do so because it's the pattern that rover uses.

bnjjj added a commit that referenced this issue Jan 27, 2023
@bnjjj
Fix the documentation to disable the Apollo telemetry (#2480)
94ae8f9 
- Fix #2478

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj
Copy link
Contributor

bnjjj commented Jan 27, 2023

Let's keep this issue open then

@bnjjj bnjjj reopened this Jan 27, 2023
@bnjjj bnjjj mentioned this issue Jan 30, 2023
Closed
@abernix abernix mentioned this issue Feb 1, 2023
Merged
@bnjjj bnjjj removed their assignment May 17, 2023
@Mark90 Mark90 mentioned this issue Aug 18, 2023
Closed
@abernix abernix removed the triage label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
raised by user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abernix @bnjjj @Meemaw