Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No http otlp exporter suported #4559

Closed
andre-c-alves opened this issue Jan 28, 2024 · 1 comment · Fixed by #4842
Closed

No http otlp exporter suported #4559

andre-c-alves opened this issue Jan 28, 2024 · 1 comment · Fixed by #4842
Assignees

Comments

@andre-c-alves
Copy link

andre-c-alves commented Jan 28, 2024

I'm trying de following configuration (export metrics to Dynatrace)

telemetry: exporters: metrics: otlp: # Enable the OpenTelemetry exporter enabled: true endpoint: defaut protocol: http

but I got the message:
"ERROR plugin apollo.telemetry could not be configured: otlp metric export does not support http yet"

It's working for tracing, but not for metrics. Does anyone have idea?

@BrynCooke
Copy link
Contributor

The issue is still open in open-telemetry/opentelemetry-rust#772, but it looks like from the code this is now supported. We should take another look, or maybe you could raise a PR?

BrynCooke pushed a commit that referenced this issue Mar 25, 2024
Previously we only supported OTLP Grpc, but since this was fixed upstream we can now enable http.

Added integration tests
Fixes #4559
BrynCooke pushed a commit that referenced this issue Mar 25, 2024
Previously we only supported OTLP Grpc, but since this was fixed upstream we can now enable http.

Added integration tests
Fixes #4559
BrynCooke pushed a commit that referenced this issue Mar 25, 2024
Previously we only supported OTLP Grpc, but since this was fixed upstream we can now enable http.

Added integration tests
Fixes #4559
BrynCooke pushed a commit that referenced this issue Mar 29, 2024
Previously we only supported OTLP Grpc, but since this was fixed upstream we can now enable http.

This involved a pretty major overhaul of integration tests to make sure that this was working as expected.
Fixes #4559
BrynCooke pushed a commit that referenced this issue Mar 29, 2024
Previously we only supported OTLP Grpc, but since this was fixed upstream we can now enable http.

This involved a pretty major overhaul of integration tests to make sure that this was working as expected.
Fixes #4559
BrynCooke added a commit that referenced this issue Apr 2, 2024
Users can now export metrics via OTLP Http in addition to the existing
OTLP Grpc

Activate this by setting the `protocol` to `http` in your your
`router.yaml`:

```
telemetry:
  exporters:
    metrics:
      otlp:
        enabled: true
        protocol: http
```

Fixes #4559


<!-- start metadata -->
---

**Checklist**

Complete the checklist (and note appropriate exceptions) before the PR
is marked ready-for-review.

- [ ] Changes are compatible[^1]
- [ ] Documentation[^2] completed
- [ ] Performance impact assessed and acceptable
- Tests added and passing[^3]
    - [ ] Unit Tests
    - [ ] Integration Tests
    - [ ] Manual Tests

**Exceptions**

*Note any exceptions here*

**Notes**

[^1]: It may be appropriate to bring upcoming changes to the attention
of other (impacted) groups. Please endeavour to do this before seeking
PR approval. The mechanism for doing this will vary considerably, so use
your judgement as to how and when to do this.
[^2]: Configuration is an important part of many changes. Where
applicable please try to document configuration examples.
[^3]: Tick whichever testing boxes are applicable. If you are adding
Manual Tests, please document the manual testing (extensively) in the
Exceptions.

Co-authored-by: bryn <bryn@apollographql.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants