Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTLP http metrics export #4842

Merged
merged 3 commits into from Apr 2, 2024
Merged

Add OTLP http metrics export #4842

merged 3 commits into from Apr 2, 2024

Conversation

BrynCooke
Copy link
Contributor

Users can now export metrics via OTLP Http in addition to the existing OTLP Grpc

Activate this by setting the protocol to http in your your router.yaml:

telemetry:
  exporters:
    metrics:
      otlp:
        enabled: true
        protocol: http

Fixes #4559


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Mar 25, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • xlarge-request - Stress test with 10 MB request payload
  • step - Basic stress test that steps up the number of users over time

Previously we only supported OTLP Grpc, but since this was fixed upstream we can now enable http.

This involved a pretty major overhaul of integration tests to make sure that this was working as expected.
Fixes #4559
@BrynCooke BrynCooke force-pushed the bryn/enable-otelp-http-metrics branch from ab60286 to 7e14c0f Compare March 29, 2024 12:12
@BrynCooke BrynCooke requested a review from garypen April 2, 2024 07:51
@BrynCooke BrynCooke merged commit 0df629f into dev Apr 2, 2024
14 checks passed
@BrynCooke BrynCooke deleted the bryn/enable-otelp-http-metrics branch April 2, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No http otlp exporter suported
2 participants