Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates some readme wording #1445

Merged
merged 2 commits into from
Jul 29, 2022
Merged

docs: updates some readme wording #1445

merged 2 commits into from
Jul 29, 2022

Conversation

EverlastingBugstopper
Copy link
Contributor

This PR updates some wording in the router docs. Some of these changes y'all may not want to make, but I think most of them are helpful changes.

@github-actions

This comment has been minimized.

@EverlastingBugstopper
Copy link
Contributor Author

do we need a changelog entry for this? methinks not but i'm not sure how y'all do things over in these here parts

@o0Ignition0o
Copy link
Contributor

We tend to add an entry, which allows your nickname to show up in the release notes :D I'd put it in the docs, or maybe the chore section if you feel like writing an entry!

Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this! LGTM, @EverlastingBugstopper . :shipit:

@abernix abernix merged commit e103530 into main Jul 29, 2022
@abernix abernix deleted the avery/readme-updates branch July 29, 2022 19:14
@garypen garypen added this to the v0.14.0 milestone Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants