feat: decrease CI build times - low hanging fruits #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok so it turns out i circleci doesn't allow us to curl docker-compose containers. it means we cannot remove nodejs from the ci env. the good news though is that it's for CI only |
o0Ignition0o
changed the title
This commit does a couple of things that lower CI build times: - Separate and run lints / builds / tests in parallel - Cache node_modules (in tests), and cargo build output - Run cargo test --no-run while we're waiting for the nodejs subservices to be up and running The overall goal is to let the CI fail as early as possible (lint -> build -> tests).
o0Ignition0o
force-pushed
the
igni/ci
branch
from
b8cdd6b
to
e3d9a0e
Compare
o0Ignition0o
requested review from
cecton,
BrynCooke,
abernix and
Geal
and removed request for
cecton
cecton
reviewed
Nov 18, 2021
o0Ignition0o
changed the title
cecton
reviewed
Nov 18, 2021
…irst step towards cargo about verification) and add cargo xtask check-compliance step to the CI
…e job is faster than xtask_lint.
…o see how the new step behaves
cecton
approved these changes
Nov 19, 2021
| @@ -3,9 +3,9 @@ use structopt::StructOpt; | |||
| use xtask::*; | |||
|
|
|||
| #[derive(Debug, StructOpt)] | |||
| pub struct Check {} | |||
There was a problem hiding this comment.
I mean "Compliance" sounds good
…lag to explicitly disable the behavior
cecton
reviewed
Nov 19, 2021
Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>
Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>
cecton
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: decrease CI build times.
This commit lowers the CI build times by up to 50%, by doing the following:
There's still quite a couple more things we can do, to decrease the CI build times further, which are being discussed in #157