Reintroduce health liveliness check #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
o0Ignition0o
commented
Sep 21, 2022
o0Ignition0o
changed the title
|
let's think about how these gql queries get (or shouldn't get) reported to studio. |
|
(moved conversation from slack) I'm using OTel for traces and I'm seeing a million health check traces that distract from the useful ones. Any ideas on how to avoid that? Thanks for adding this back! |
garypen
requested changes
Sep 22, 2022
...uter/src/configuration/snapshots/apollo_router__configuration__tests__schema_generation.snap
Outdated
Show resolved
Hide resolved
Geal
reviewed
Sep 22, 2022
| ); | ||
| .expect("query is always valid"); | ||
| async move { | ||
| let (parts, body) = run_graphql_request(service, health_check_request) |
There was a problem hiding this comment.
instead of calling run_graphql_request and needing to deserialize json, maybe this could reproduce this part of the run_graphql_request function?
There was a problem hiding this comment.
We're going with a static response for now
added 2 commits
September 22, 2022 09:34
Geal
approved these changes
Sep 22, 2022
garypen
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1861
fixes #1852
Reintroduce health liveliness check (Issue #1861)
Depending on their environments and cloud settings, users may or may not be able to craft health probes that are able to make CSRF compatible GraphQL queries.
This is one of the reasons why we reintroduced a health check in the router.
The health liveness check endpoint is exposed on
127.0.0.1:8088/health, and its listen address can be changed in the yaml configuration: