prometheus: make sure http_requests_error_total and http_requests_total are incremented.
#1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
o0Ignition0o
changed the title
http_requests_error_total and http_requests_total are incremented.
|
Manually requesting reviews from @BrynCooke and @bnjjj because They probably have the most context, and I'm not sure what their intent was when this was built. |
o0Ignition0o
force-pushed
the
igni/validation_request_errors
branch
from
d893881
to
e6ba92d
Compare
bnjjj
approved these changes
Oct 18, 2022
BrynCooke
approved these changes
Oct 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1954
prometheus: make sure http_requests_error_total and http_requests_total are incremented. (PR #1953)
http_requests_error_totaldid only increment for requests that would be anINTERNAL_SERVER_ERRORin the router (the service stack returning a BoxError).What this means is that validation errors would not increment this counter.
http_requests_totalwould only increment for successful requests, while the prometheus documentation mentions this key should be incremented regardless of whether the request succeeded or not.This PR makes sure we always increment
http_requests_total, and we incrementhttp_requests_error_totalwhen the StatusCode is not 2XX.