Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(telemetry.apollo): add documentation about send_headers and send_variable_value #2435

Merged
merged 8 commits into from
Jan 25, 2023
Merged

docs(telemetry.apollo): add documentation about send_headers and send_variable_value #2435

merged 8 commits into from
Jan 25, 2023

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Jan 19, 2023

@bnjjj
docs(telemetry): add documentation about 'send_headers' and 'send_var…
c601d7c 
…iable_value'

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj added the documentation Improvements or additions to documentation label Jan 19, 2023
@bnjjj bnjjj self-assigned this Jan 19, 2023
@github-actions

This comment has been minimized.

Sign in to view
@bnjjj
changelog
67ab296 
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
abernix
abernix reviewed Jan 20, 2023
View reviewed changes
NEXT_CHANGELOG.md Outdated Show resolved Hide resolved
docs/source/configuration/apollo-telemetry.mdx Outdated Show resolved Hide resolved
docs/source/configuration/apollo-telemetry.mdx Outdated Show resolved Hide resolved
NEXT_CHANGELOG.md Outdated Show resolved Hide resolved
abernix
abernix approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some comments I left below, but nice work on this!

Geal
Geal approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@Geal Geal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with the fixes suggested by @abernix

bnjjj and others added 4 commits January 20, 2023 11:38
@bnjjj @abernix
Update NEXT_CHANGELOG.md
3f166c5 
Co-authored-by: Jesse Rosenberger <git@jro.cc>
@bnjjj @abernix
Update docs/source/configuration/apollo-telemetry.mdx
95edc12 
Co-authored-by: Jesse Rosenberger <git@jro.cc>
@bnjjj @abernix
Update docs/source/configuration/apollo-telemetry.mdx
b15a164 
Co-authored-by: Jesse Rosenberger <git@jro.cc>
@bnjjj @abernix
Update NEXT_CHANGELOG.md
492b5ef 
Co-authored-by: Jesse Rosenberger <git@jro.cc>
@bnjjj bnjjj enabled auto-merge (squash) January 20, 2023 10:39
@bnjjj bnjjj merged commit e980787 into dev Jan 25, 2023
@bnjjj bnjjj deleted the bnjjj/docs_2419 branch January 25, 2023 10:17
@abernix abernix mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geal Geal Geal approved these changes

@BrynCooke BrynCooke BrynCooke approved these changes

@abernix abernix abernix approved these changes

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

@garypen garypen Awaiting requested review from garypen

Assignees

@bnjjj bnjjj

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telemetry: document telemetry.apollo.send_headers.
4 participants
@bnjjj @Geal @BrynCooke @abernix