Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rhai example for header->client propagation #2474

Merged

Conversation

lennyburdette
Copy link
Contributor

Shows how to send set-cookie headers from subgraphs to clients with rhai scripting.

Related to #1284

  • Fix #issue_number

description here

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

Shows how to send set-cookie headers from subgraphs to clients with rhai scripting.

Related to apollographql#1284
@lennyburdette lennyburdette force-pushed the lb/doc-subgraph-headers-to-clients branch from 1ad7bda to d395073 Compare January 25, 2023 17:27
Co-authored-by: Erik Bylund <ebylund@users.noreply.github.com>
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I did spot one edit worth applying.

docs/source/configuration/header-propagation.mdx Outdated Show resolved Hide resolved
@abernix abernix merged commit 3c012e2 into apollographql:dev Feb 1, 2023
@abernix abernix mentioned this pull request Feb 1, 2023
@lennyburdette lennyburdette deleted the lb/doc-subgraph-headers-to-clients branch February 8, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants