Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always instantiate the traffic shaping plugin #3330

Merged
merged 7 commits into from
Jun 30, 2023

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Jun 28, 2023

Fix #3327

that plugin is always part of the plugins list and should always be active, with default configuration

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

that plugin is always part of the plugins list and should always be
active, with default configuration
@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Jun 28, 2023

CI performance tests

  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • xlarge-request - Stress test with 10 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • large-request - Stress test with a 1 MB request payload

@Geal Geal requested review from a team, garypen, SimonSapin and o0Ignition0o June 28, 2023 15:18
@garypen garypen changed the title always instanciate the traffic shaping plugin always instantiate the traffic shaping plugin Jun 28, 2023
@garypen garypen self-requested a review June 29, 2023 07:57
@Geal Geal enabled auto-merge (squash) June 30, 2023 13:41
@Geal Geal merged commit 6281d02 into dev Jun 30, 2023
12 checks passed
@Geal Geal deleted the geal/always-create-traffic-shaping branch June 30, 2023 15:34
@BrynCooke BrynCooke mentioned this pull request Jul 7, 2023
BrynCooke pushed a commit that referenced this pull request Jul 12, 2023
Fix #3327

that plugin is always part of the plugins list and should always be
active, with default configuration
abernix added a commit that referenced this pull request Apr 29, 2024
Traffic shaping is always instantiated since #3330 

---------

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Co-authored-by: Maria Elisabeth Schreiber <maria.schreiber@apollographql.com>
Co-authored-by: Jesse Rosenberger <git@jro.cc>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
@BrynCooke BrynCooke mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always instantiate traffic shaping
3 participants