Update deno, so we can generate docs again #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
CI performance tests
|
o0Ignition0o
commented
Aug 24, 2023
| Condition: | ||
| condition: sendValue | ||
| if_clause: | ||
| Flatten: |
There was a problem hiding this comment.
@Geal I've tagged you as reviewer since this needs attention and i /think/ you worked on it for the auth pr
o0Ignition0o
commented
Aug 24, 2023
| @@ -22,6 +22,7 @@ To compile the Apollo Router, you need to have the following installed: | |||
| <!-- renovate-automation: rustc version --> | |||
| * [Rust 1.71.1 or later](https://www.rust-lang.org/tools/install) | |||
| * [Node.js 16.9.1 or later](https://nodejs.org/en/download/) | |||
| * [CMake 3.5.1 or later](https://cmake.org/download/) | |||
There was a problem hiding this comment.
Should we add protoc to the prerequisites?
bnjjj
approved these changes
Aug 24, 2023
Merged
Merged
glasser
reviewed
Sep 7, 2023
| @@ -22,6 +22,7 @@ To compile the Apollo Router, you need to have the following installed: | |||
| <!-- renovate-automation: rustc version --> | |||
| * [Rust 1.71.1 or later](https://www.rust-lang.org/tools/install) | |||
| * [Node.js 16.9.1 or later](https://nodejs.org/en/download/) | |||
| * [CMake 3.5.1 or later](https://cmake.org/download/) | |||
There was a problem hiding this comment.
@o0Ignition0o Should we retroactively add something to CHANGELOG saying that as of v1.29.0, building Router from source requires CMake to be installed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3305, #3684
Router docs failed to build on crates.io because of a documentation compile error in Deno.
This updates Deno to the latest version, which allows us to generate crates.io documentation again.