Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sha256 support to rhai #4940

Merged
merged 8 commits into from
Apr 16, 2024
Merged

add sha256 support to rhai #4940

merged 8 commits into from
Apr 16, 2024

Conversation

lleadbet
Copy link
Contributor

This adds a new sha256::digest function to Rhai to enable hash values.

Fixes #4939

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

@lleadbet lleadbet requested a review from a team as a code owner April 10, 2024 20:43
garypen
garypen reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It looks good, just a few little NITS to sort out.

apollo-router/src/plugins/rhai/engine.rs Outdated Show resolved Hide resolved
docs/source/customizations/rhai-api.mdx Outdated Show resolved Hide resolved
docs/source/customizations/rhai-api.mdx Outdated Show resolved Hide resolved
@garypen garypen self-assigned this Apr 11, 2024
@lleadbet lleadbet requested a review from garypen April 11, 2024 13:12
garypen
garypen reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've lost a </Note> somewhere. I think it should be under the base64 section.

@garypen garypen merged commit ab069ef into apollographql:dev Apr 16, 2024
12 of 13 checks passed
@abernix abernix mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnjjj bnjjj bnjjj left review comments

@garypen garypen garypen approved these changes

@o0Ignition0o o0Ignition0o o0Ignition0o approved these changes

Assignees

@garypen garypen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Rhai sha256 hashing function
5 participants
@lleadbet @garypen @bnjjj @o0Ignition0o @abernix