Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of response status_code in rhai #5045

Merged
merged 9 commits into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
44 changes: 44 additions & 0 deletions apollo-router/src/plugins/rhai/engine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ use http::uri::Parts;
use http::uri::PathAndQuery;
use http::HeaderMap;
use http::Method;
use http::StatusCode;
use http::Uri;
use rhai::module_resolvers::FileModuleResolver;
use rhai::plugin::*;
Expand Down Expand Up @@ -218,6 +219,34 @@ mod router_method {
}
}

#[export_module]
mod status_code {
pub(crate) type StatusCode = http::StatusCode;

#[rhai_fn(name = "to_string", pure)]
pub(crate) fn status_code_to_string(status_code: &mut StatusCode) -> String {
status_code.as_str().to_string()
}

#[rhai_fn(name = "to_number", pure)]
pub(crate) fn status_code_to_number(status_code: &mut StatusCode) -> i64 {
status_code.as_u16() as i64
}
bnjjj marked this conversation as resolved.
Show resolved Hide resolved

#[rhai_fn(name = "==", pure)]
pub(crate) fn status_code_equal_comparator(status_code: &mut StatusCode, other: i64) -> bool {
status_code.as_u16() as i64 == other
}

#[rhai_fn(name = "!=", pure)]
pub(crate) fn status_code_not_equal_comparator(
status_code: &mut StatusCode,
other: i64,
) -> bool {
status_code.as_u16() as i64 != other
}
bnjjj marked this conversation as resolved.
Show resolved Hide resolved
}

#[export_module]
mod router_header_map {
pub(crate) type HeaderMap = http::HeaderMap;
Expand Down Expand Up @@ -1425,6 +1454,13 @@ macro_rules! register_rhai_router_interface {
}
);

$engine.register_get(
"status_code",
|obj: &mut SharedMut<$base::Response>| -> Result<StatusCode, Box<EvalAltResult>> {
Ok(obj.with_mut(|response| response.response.status()))
}
);

$engine.register_set(
"uri",
|obj: &mut SharedMut<$base::Request>, uri: Uri| {
Expand Down Expand Up @@ -1460,6 +1496,13 @@ macro_rules! register_rhai_interface {
}
);

$engine.register_get(
"status_code",
|obj: &mut SharedMut<$base::Response>| -> Result<StatusCode, Box<EvalAltResult>> {
Ok(obj.with_mut(|response| response.response.status()))
}
);

$engine.register_set(
"context",
|obj: &mut SharedMut<$base::Request>, context: Context| {
Expand Down Expand Up @@ -1632,6 +1675,7 @@ impl Rhai {
let mut module = exported_module!(router_plugin);
combine_with_exported_module!(&mut module, "header", router_header_map);
combine_with_exported_module!(&mut module, "method", router_method);
combine_with_exported_module!(&mut module, "status_code", status_code);
combine_with_exported_module!(&mut module, "context", router_context);

let base64_module = exported_module!(router_base64);
Expand Down
6 changes: 5 additions & 1 deletion apollo-router/src/plugins/rhai/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,11 @@ async fn it_can_process_subgraph_response() {

// We must wrap our canned response in Arc<Mutex<Option<>>> to keep the rhai runtime
// happy
let response = Arc::new(Mutex::new(Some(subgraph::Response::fake_builder().build())));
let response = Arc::new(Mutex::new(Some(
subgraph::Response::fake_builder()
.status_code(StatusCode::OK)
.build(),
)));

// Call our rhai test function. If it return an error, the test failed.
let result: Result<(), Box<rhai::EvalAltResult>> = block.engine.call_fn(
Expand Down
6 changes: 6 additions & 0 deletions apollo-router/tests/fixtures/request_response_test.rhai
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,12 @@ fn process_execution_response(response) {

fn process_subgraph_response(response) {
process_common_response(response);
if type_of(response.status_code) != "http::status::StatusCode" {
throw(`status_code: expected: "i32", actual: ${type_of(response.status_code)}`);
}
if response.status_code.to_number() != 200 {
throw(`status_code: expected: 200, actual: ${response.status_code}`);
}
}

fn process_subgraph_response_om_forbidden(response) {
Expand Down
15 changes: 15 additions & 0 deletions docs/source/customizations/rhai-api.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,7 @@ The `response` object includes the following fields:
```
response.context
response.id
response.status_code
response.headers
response.body.label
response.body.data
Expand Down Expand Up @@ -618,3 +619,17 @@ let error_to_add = #{
response.body.errors += error_to_add;
print(`${response.body.errors}`); // logs the response errors
```

### `response.status_code.to_string()`

Convert response status code as a string
bnjjj marked this conversation as resolved.
Show resolved Hide resolved

### `response.status_code.to_number()`

Convert response status code as a number in order to compare it
bnjjj marked this conversation as resolved.
Show resolved Hide resolved

```rhai
if response.status_code.to_number() == 200 {
print(`ok`);
}
```