Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of response status_code in rhai #5045

Merged
merged 9 commits into from May 14, 2024
Merged

add support of response status_code in rhai #5045

merged 9 commits into from May 14, 2024

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Apr 29, 2024

Added support of response.status_code on Response interface in rhai.

Convert response status code to a string.

if response.status_code.to_string() == "200" {
    print(`ok`);
}

Also useful if you want to convert response status code to a number

if parse_int(response.status_code.to_string()) == 200 {
    print(`ok`);
}

Fixes #5042


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from a team as a code owner April 29, 2024 15:32
@bnjjj bnjjj requested review from garypen and Geal April 29, 2024 15:32

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Apr 29, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be addressing wide scope than the original issue (i.e.: status codes on many responses, not just SubgraphResponse). Perhaps note that somewhere by updating the issue or the PR description?

apollo-router/src/plugins/rhai/engine.rs Outdated Show resolved Hide resolved
apollo-router/src/plugins/rhai/engine.rs Outdated Show resolved Hide resolved
docs/source/customizations/rhai-api.mdx Outdated Show resolved Hide resolved
docs/source/customizations/rhai-api.mdx Outdated Show resolved Hide resolved
abernix and others added 5 commits May 3, 2024 22:12
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from garypen May 13, 2024 09:59
bnjjj added 2 commits May 13, 2024 12:30
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Nits, but this looks good.

.changesets/feat_bnjjj_fix_5042.md Outdated Show resolved Hide resolved
.changesets/feat_bnjjj_fix_5042.md Outdated Show resolved Hide resolved
apollo-router/src/plugins/rhai/engine.rs Outdated Show resolved Hide resolved
Co-authored-by: Gary Pennington <gary@apollographql.com>
@bnjjj bnjjj requested a review from garypen May 13, 2024 13:37
@bnjjj bnjjj enabled auto-merge (squash) May 13, 2024 13:41
@bnjjj bnjjj merged commit 3aa271d into dev May 14, 2024
13 of 14 checks passed
@bnjjj bnjjj deleted the bnjjj/fix_5042 branch May 14, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for response status code in rhai
4 participants