Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): prioritize the --supergraph arg when APOLLO_KEY is set #535

Merged
merged 2 commits into from
Feb 25, 2022
Merged

fix(router): prioritize the --supergraph arg when APOLLO_KEY is set #535

merged 2 commits into from
Feb 25, 2022

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Feb 23, 2022

close #534

@bnjjj
fix(router): prioritize the --supergraph arg when APOLLO_KEY is set
84a11a8 
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
abernix
abernix reviewed Feb 23, 2022
View reviewed changes
apollo-router/src/main.rs Outdated Show resolved Hide resolved
abernix
abernix reviewed Feb 23, 2022
View reviewed changes
apollo-router/src/main.rs Outdated Show resolved Hide resolved
abernix
abernix reviewed Feb 23, 2022
View reviewed changes
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll let someone else review the logic, but I left a couple nits on the messaging (as I tend to do).

@bnjjj @abernix
Apply suggestions from code review
df5a5ad 
Co-authored-by: Jesse Rosenberger <git@jro.cc>
garypen
garypen approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Small language change which I hope is clearer. I'm approving anyway, since what you have is clear enough.

apollo-router/src/main.rs Show resolved Hide resolved
@bnjjj bnjjj mentioned this pull request Feb 25, 2022
Closed
@bnjjj bnjjj merged commit 313a5ca into main Feb 25, 2022
@bnjjj bnjjj deleted the bnjjj/fix_534 branch February 25, 2022 08:57
@abernix abernix mentioned this pull request Feb 25, 2022
Merged
@abernix abernix added this to the v0.1.0-alpha.8 milestone Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garypen garypen garypen approved these changes

@abernix abernix abernix left review comments

Assignees

@bnjjj bnjjj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DX when --supergraph and Managed Federation are both enabled
3 participants
@bnjjj @garypen @abernix