Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add opentracing layer #548

Merged
merged 5 commits into from Mar 2, 2022
Merged

add opentracing layer #548

merged 5 commits into from Mar 2, 2022

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Feb 24, 2022

Add an opentracing layer to keep backward compatibility
close #517

Currently in draft, I need to check if all needed formats are supported

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj marked this pull request as ready for review February 28, 2022 13:28
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj force-pushed the bnjjj/add_opentracing_plugin branch from 340c8d0 to 3988b1e Compare February 28, 2022 13:31
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a couple of questions about the requirement for a new span.

apollo-router/src/layers/opentracing.rs Outdated Show resolved Hide resolved
@garypen garypen self-requested a review March 1, 2022 08:54
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj merged commit f379937 into main Mar 2, 2022
@bnjjj bnjjj deleted the bnjjj/add_opentracing_plugin branch March 2, 2022 09:18
@abernix abernix mentioned this pull request Mar 8, 2022
@abernix abernix added this to the v0.1.0-alpha.8 milestone Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support opentracing for subgraphs
5 participants