-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use spawn_blocking for parsing #5582
Conversation
CI performance tests
|
it looks like there's some flakiness in the tests with the snapshots https://app.circleci.com/pipelines/github/apollographql/router/23631/workflows/0230bc91-f65c-47a1-ae33-6128fae26325/jobs/165914?invite=true#step-117-361965_43 |
There is indeed an on-going something or another in the tests. @BrynCooke did try to look at this today, but will not be around for the next couple weeks, and I'm not sure will get back to it. I will highlight that there is still conversation that wasn't answered from the original PR that might be worth discussing: @xuorig wrote:
|
As per the extensive commentary here: https://docs.rs/tracing/latest/tracing/span/struct.Span.html#method.or_current Let's see if this fixes things.
They should be the same as in dev.
Not sure exactly what is happening here, but ...
This might be the solution I've been looking for. Make sure to create the spawn outside of the call to spawn_blocking.
Thanks @garypen for finishing that one |
This leverages the work that @xuorig started in #5235 with a number of necessary follow-up fixes to get it into the shape we'll need to land it.
I have checked manually that the span duplication in the snapshot has no impact on traces reported to aggregators, it's more of an artifact of our way to gather spans in the test.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩