-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(federation): reduce strcmp by swapping a couple of conditions #5667
Conversation
@o0Ignition0o, please consider creating a changeset entry in |
If we do this we should add a comment to these cases I think. They read better when the subgraph name is at the start, so just saying "we compare the subgraph name last because on average it improves performance" would be helpful |
true! adding comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm when ci passes ;p
Sneaky whitespace 😅 rerunning CI! |
CI performance tests
|
No description provided.