Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): reduce strcmp by swapping a couple of conditions #5667

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

o0Ignition0o
Copy link
Contributor

No description provided.

Copy link
Contributor

@o0Ignition0o, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@goto-bus-stop
Copy link
Member

If we do this we should add a comment to these cases I think. They read better when the subgraph name is at the start, so just saying "we compare the subgraph name last because on average it improves performance" would be helpful

@o0Ignition0o
Copy link
Contributor Author

If we do this we should add a comment to these cases I think. They read better when the subgraph name is at the start, so just saying "we compare the subgraph name last because on average it improves performance" would be helpful

true! adding comments

Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when ci passes ;p

@goto-bus-stop goto-bus-stop changed the title Reduce strcmp by swapping a couple of conditions fix(federation): reduce strcmp by swapping a couple of conditions Jul 17, 2024
@o0Ignition0o
Copy link
Contributor Author

Sneaky whitespace 😅 rerunning CI!

@o0Ignition0o o0Ignition0o merged commit 1b0a218 into dev Jul 18, 2024
13 checks passed
@o0Ignition0o o0Ignition0o deleted the igni/reduce_strcmp branch July 18, 2024 08:41
@router-perf
Copy link

router-perf bot commented Jul 19, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants