Move apollo plugins to top level #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 14, 2022 16:11
… with the json schema. Previously if two config structs had the same name they would be resolved to the same definition. GREsau/schemars#62
Now we have `apollo_plugins` and `user_plugins`
Reporting comes first, rhai comes last.
This comment has been minimized.
This comment has been minimized.
We can't enable the reporting plugin for unit testing, so check to see if the global subscriber is set before adding it.
BrynCooke
force-pushed
the
bryn/apollo-plugins-to-top-level
branch
from
f3eafa7
to
ac2c142
Compare
added 2 commits
March 14, 2022 18:27
|
Perf test please |
1 similar comment
|
Perf test please |
Geal
reviewed
Mar 15, 2022
Geal
approved these changes
Mar 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any plugins that are prefixed with
apollo.are pushed to the top level of configuration.This means that whereas we previously had:
It now looks like:
The reason for this is that it gives the user a clearer idea of what is core to the router and what is an external plugin.
We'll follow this up with a PR to update the name of reporting plugin and then take a general sweep to update all the docs.