New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document dynamic composition versions #1087
Conversation
✅ Deploy Preview for apollo-cli-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some recommendations!
10d89bc
to
b1421b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐐 Added some suggestions, but none blocking. Nice improvement!
I've made enough changes here that I think it's worth re-requesting a review from both of y'all. Thanks so much for the time on this I'm excited about shipping these docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions!
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
cc @StephenBarlow for wording and @pcmanus for veracity - i'm a little shaky around if my claim that future changes won't break is true, and we should also likely have minimum gateway versions that we can commit to this stability for.