Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document dynamic composition versions #1087

Merged
merged 14 commits into from Apr 14, 2022

Conversation

EverlastingBugstopper
Copy link
Contributor

cc @StephenBarlow for wording and @pcmanus for veracity - i'm a little shaky around if my claim that future changes won't break is true, and we should also likely have minimum gateway versions that we can commit to this stability for.

@netlify
Copy link

netlify bot commented Apr 12, 2022

Deploy Preview for apollo-cli-docs ready!

Name Link
🔨 Latest commit b9eb33e
🔍 Latest deploy log https://app.netlify.com/sites/apollo-cli-docs/deploys/62585e1011c204000864d2cc
😎 Deploy Preview https://deploy-preview-1087--apollo-cli-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@StephenBarlow StephenBarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some recommendations!

docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@benweatherman benweatherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐 Added some suggestions, but none blocking. Nice improvement!

docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
@EverlastingBugstopper
Copy link
Contributor Author

I've made enough changes here that I think it's worth re-requesting a review from both of y'all. Thanks so much for the time on this I'm excited about shipping these docs.

@EverlastingBugstopper EverlastingBugstopper added the docs 📝 improvements or additions to docs on the docs site label Apr 13, 2022
@EverlastingBugstopper EverlastingBugstopper added this to the 0.5.2 milestone Apr 13, 2022
Copy link
Contributor

@StephenBarlow StephenBarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions!

docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
@EverlastingBugstopper EverlastingBugstopper merged commit 1fb6f4a into main Apr 14, 2022
@EverlastingBugstopper EverlastingBugstopper deleted the avery/supergraph-docs branch April 14, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs 📝 improvements or additions to docs on the docs site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants