Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch typings #260

Merged
merged 9 commits into from
Jan 12, 2017
Merged

Switch typings #260

merged 9 commits into from
Jan 12, 2017

Conversation

stubailo
Copy link
Contributor

@stubailo stubailo commented Jan 5, 2017

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@DxCx
Copy link
Contributor

DxCx commented Jan 12, 2017

why not continuing what i've started (#215)?

@DxCx DxCx added 🍳 breaking-change Needs to wait for a major release. tag: polish labels Jan 12, 2017
@helfer
Copy link
Contributor

helfer commented Jan 12, 2017

@DxCx I think we simply overlooked it when we started this PR because we were switching it for all the other repos at the same time, and none of them had an open PR.

@helfer helfer mentioned this pull request Jan 12, 2017
Closed
@helfer helfer merged commit 780a9eb into master Jan 12, 2017
@helfer helfer deleted the switch-typings branch January 12, 2017 16:04
@DxCx
Copy link
Contributor

DxCx commented Jan 12, 2017

nice! thanks 👍

trevor-scheer pushed a commit that referenced this pull request May 6, 2020
@abernix
Use a special environment variable for testing rather than `NODE… (#260)
c7bfeaf 
Use a special environment variable for testing rather than `NODE_ENV`.
trevor-scheer pushed a commit that referenced this pull request May 12, 2020
@abernix
Use a special environment variable for testing rather than `NODE… (#260)
bc313e0 
Use a special environment variable for testing rather than `NODE_ENV`.
trevor-scheer pushed a commit that referenced this pull request May 14, 2020
@abernix
Use a special environment variable for testing rather than `NODE… (#260)
8191d37 
Use a special environment variable for testing rather than `NODE_ENV`.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
🍳 breaking-change Needs to wait for a major release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stubailo @DxCx @helfer