This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Update to Apollo Client 0.5 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
October 17, 2016 23:41
tmeasday
reviewed
Oct 18, 2016
| @@ -21,7 +21,7 @@ describe('App', () => { | |||
| const query = gql`query people { allPeople(first: 1) { people { name } } }`; | |||
| const data = { allPeople: { people: { name: 'Luke Skywalker' } } }; | |||
| const networkInterface = mockNetworkInterface({ request: { query }, result: { data } }); | |||
| const client = new ApolloClient({ networkInterface }); | |||
| const client = new ApolloClient({ networkInterface, addTypename: false }); | |||
There was a problem hiding this comment.
Why do this all over the place and default the network interface to supporting it?
There was a problem hiding this comment.
What's the alternative?
There was a problem hiding this comment.
I thought we discussed making mockNetworkInterface support adding __typename to results automatically so we didn't have to worry about it in tests.
There was a problem hiding this comment.
Oh, right. I guess this seemed easier for now.
There was a problem hiding this comment.
Yeah I guess it just seems like the sort of change that is hard to back out later. But i'll merge it and do that later today.
stubailo
commented
Oct 18, 2016
| @@ -66,8 +65,18 @@ const defaultMapResultToProps = props => props; | |||
| const defaultMapPropsToSkip = props => false; | |||
|
|
|||
| // the fields we want to copy over to our data prop | |||
| const observableQueryFields = observable => pick(observable, 'variables', | |||
| 'refetch', 'fetchMore', 'updateQuery', 'startPolling', 'stopPolling'); | |||
| function observableQueryFields(observable) { | |||
There was a problem hiding this comment.
I can patch. I don't think there's a big cost to more releases right.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blockers:
Tests passing:
TODO: