-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some questions in the dataset are wrong with {tail2} #13
Comments
Hi Yonghao Thanks for your interest! Yes this question template unfortunately did not get filled properly during dataset construction, and there exist some faulty questions like you mentioned. We will fix these in a v2 of the dataset, but in order to keep consistency in the reported numbers we are not changing anything in the current version. |
Thanks a lot! Looking forward to v2 :) |
Closing issue here, but will leave it pinned since its important |
We have fixed the {tail2} issue. There's no other change in the dataset for now |
In v2 training data, some question templates still contain tail2. How could I solve it? For example, |
KeyError: Caught KeyError in DataLoader worker process 0. |
have same error,did you fix it? |
Yes, in each question dictionary, there are two keys: "template" and
"question" (I cannot remember clearly). One shows a question like "Who is
the {head} of {tail}", one shows a question like "Who is the Q124 of Q456".
You can identify {tail2} by matching these two. The sequence of each word
is the same in them.
…On Fri, May 19, 2023 at 11:09 AM liwenju0 ***@***.***> wrote:
have same error,did you fix it?
—
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKVPXQPIOFNNIULESXVSRFTXG3QAPANCNFSM5LX34PAQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Hi! @apoorvumang Amazing work here!
I found that some questions in the dataset with the type of "time_join" are wrong, in which there's a {tail2} in the template that is not correctly mapped. Some examples are:
"When Q300269 was the Q37303731 , who was the {tail2}"
"Who was {tail2} when Q6105302 was the Q41582582"
I wonder if there are some problems with templates like the following or something else?
"Who was the {tail2} when {head} was the {tail}"
Thanks!
Best,
Yonghao
The text was updated successfully, but these errors were encountered: