Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverthmarklegacy #1016

Merged
merged 3 commits into from Mar 28, 2020
Merged

Reverthmarklegacy #1016

merged 3 commits into from Mar 28, 2020

Conversation

amitlimaye
Copy link
Contributor

Description

Changes proposed in this pull request.

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

@aporeto-bot
Copy link
Collaborator

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1643",
    "commit-sha": "c999e07241a248a8b6c4f7d20bb3fb8aef2473b8",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "1016",
    "commit-sha": "d5600bfdf48ac936e66bea3c7c7850187037dea9",
    "pipeline": "master"
  }
]

@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #1016 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
+ Coverage   55.25%   55.25%   +<.01%     
==========================================
  Files         133      133              
  Lines       12642    12643       +1     
==========================================
+ Hits         6985     6986       +1     
  Misses       4999     4999              
  Partials      658      658
Impacted Files Coverage Δ
...ontroller/internal/supervisor/iptablesctrl/acls.go 71.08% <0%> (ø) ⬆️
...ller/internal/supervisor/iptablesctrl/templates.go 89.26% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2317a...f640e97. Read the comment docs.

@aporeto-bot
Copy link
Collaborator

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "1016",
    "commit-sha": "f640e971044ff538596c06d1b314e4e2ad3cffdd",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1643",
    "commit-sha": "c999e07241a248a8b6c4f7d20bb3fb8aef2473b8",
    "pipeline": "master"
  }
]

@aporeto-bot
Copy link
Collaborator

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1643",
    "commit-sha": "1b9bac19aa09284225d809df56d0b8bf062ea29d",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "1016",
    "commit-sha": "f640e971044ff538596c06d1b314e4e2ad3cffdd",
    "pipeline": "master"
  }
]

@aporeto-bot
Copy link
Collaborator

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "1016",
    "commit-sha": "f640e971044ff538596c06d1b314e4e2ad3cffdd",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1643",
    "commit-sha": "1b9bac19aa09284225d809df56d0b8bf062ea29d",
    "pipeline": "master"
  }
]

@amitlimaye amitlimaye merged commit fea4fd6 into master Mar 28, 2020
@amitlimaye amitlimaye deleted the reverthmarklegacy branch March 28, 2020 06:42
amitlimaye added a commit that referenced this pull request Mar 28, 2020
* Fixing Changes for rhel6 moving back to queue-balance on legacy platform

* Change mark value to packetMark

Co-authored-by: Amit Limaye <alimaye@paloaltonetworks.com>
amitlimaye added a commit that referenced this pull request Mar 28, 2020
Co-authored-by: Amit Limaye <alimaye@paloaltonetworks.com>

Co-authored-by: Amit Limaye <alimaye@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants