Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont use hmark for legacy acls (#1016) #1018

Merged
merged 1 commit into from Mar 28, 2020
Merged

Conversation

amitlimaye
Copy link
Contributor

  • Fixing Changes for rhel6 moving back to queue-balance on legacy platform

  • Change mark value to packetMark

Co-authored-by: Amit Limaye alimaye@paloaltonetworks.com

Description

Changes proposed in this pull request.

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

* Fixing Changes for rhel6 moving back to queue-balance on legacy platform

* Change mark value to packetMark

Co-authored-by: Amit Limaye <alimaye@paloaltonetworks.com>
@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #1018 into release-3.14.0 will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.14.0    #1018   +/-   ##
===============================================
  Coverage           54.80%   54.80%           
===============================================
  Files                 126      126           
  Lines               12275    12276    +1     
===============================================
+ Hits                 6727     6728    +1     
  Misses               4921     4921           
  Partials              627      627           
Impacted Files Coverage Δ
...ontroller/internal/supervisor/iptablesctrl/acls.go 68.91% <0.00%> (ø)
...ller/internal/supervisor/iptablesctrl/templates.go 87.24% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d7fbf9...77c3d87. Read the comment docs.

@amitlimaye amitlimaye merged commit 034a374 into release-3.14.0 Mar 28, 2020
@amitlimaye amitlimaye deleted the revertmark3.14 branch March 28, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant