flatten out functions, async everything, send errors to template

[stuartromanek]

No description provided.

[stuartromanek]

• flatten out functions to do one thing
• use await over then
• send errors to the template
• log all errors on server

Questions: @boutell what, if anything, should i be returning in catch blocks?

[boutell]

What I'm thinking is that only the route itself should take (req, res) and contain a try/catch and worry about sending a response in the successful and unsuccessful cases.

The rest of the methods can then be simple async functions that return something you want, giving you the full benefit of async/await - "return" actually means something useful. And you only need the one "catch" to handle any exception or rejected promise at any point.

Want to finish it up together?

[stuartromanek]

@boutell take another look? If still not right, let's get together IRL

[boutell]

That's the stuff!

Two small things:

• I don't think you need encodeUri, but if you are going to use it, be consistent. Right now you are using it when setting cache but not when getting cache so the cache is going to miss all the time for urls changed by it.

• On reflection, the request calls for individual urls deserve their own try/catch so you can put in a reasonable error response for each url rather than flunking all of them. Everywhere else though the one shared try block is working great.

[stuartromanek]

fixed up the encodeUri consistency (i ran into the need for encoding when scraping a bunch of OpenMuseum urls with special characters in the names of artwork).

To the second point, this was refactored to only make one request, even though it is formatted as an array. If that request errors it bubbles to the top catch and sends a (newly detailed) http error. Seems good?

[boutell]

Oh right, I forgot it's only one request now, mainly because there's so much array logic. Should the array logic just go away?

…

On Mon, Jan 28, 2019 at 10:04 AM Stuart Romanek ***@***.***> wrote: fixed up the encodeUri consistency (i ran into the need for encoding when scraping a bunch of OpenMuseum urls with special characters in the names of artwork). To the second point, this was refactored to only make one request, even though it is formatted as an array. If that request errors it bubbles to the top catch and sends a (newly detailed) http error. Seems good? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB9fUAZ5ynlDPRW9VFZ2MOwoqr5NV0Vks5vHxFzgaJpZM4aNG0F> .

-- *Thomas Boutell, Chief Software Architect* P'unk Avenue | (215) 755-1330 | punkave.com

[stuartromanek]

singular'ified