Pro 3247 keyboard shortcuts conflicts #3953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule * feature/keyboard-shortcut: (45 commits) remove tiptap breaking change and duplicates warnings (#3892) eslint fix various errata in the update menu Try better Changelog Manage busy wizard status to control actions disabled state Add `null` to select fields with a function name as choices (#3924) date remove TODO release 3.31.0 undo weird change aposPlaceholder: true supersedes all field values fix advisory message do not try to "convert" while aposPlaceholder is still in effect; do not clone unnecessarily; always respect placeholders regardless of field values until aposPlaceholder is cleared add widget placeholders feature (#3910) release 3.30.0 changelog, webpack context update vue-loader refactor addFileGroup method response to comments ...
map undo/redo
…cut-component' into pro-3248-apos-command-menu-shortcut-component
…cut-component' into pro-3248-apos-command-menu-shortcut-component
…b.com:apostrophecms/apostrophe into pro-3248-apos-command-menu-shortcut-component * 'pro-3248-apos-command-menu-shortcut-component' of github.com:apostrophecms/apostrophe: Disable shortcut commands when focus in rich-text editor and inputs
…d-menu-shortcut-component * pro-3244-command-menu-module: (56 commits) explicit command or group name in test compile errors from multiple modules test get all errors at once fast parking chore: prettify a bit & iterate over `Object.keys` instead of `for ... in` release 3.33.0 protect against any possibility of dcad-1191 manifesting in A3 update changelog for easier extension of the rich-text checking and adding all `defaultOptions` to the `activeOptions` Publish batch icon (#3944) dashed lines magic kill the foreign hover on mouseleave, also defensive driving Add "publish" batch feature to manager modal (#3939) Fixes based on comments add more info about PR contribution typos changelog working solution better link shiny new documentation link for email ...
…-3247-keyboard-shortcuts-conflicts
…-3247-keyboard-shortcuts-conflicts
PRO-3247 Handling keyboard shortcuts conflicts
If multiple keyboard shortcuts using the same combination of keys are registered, the system must display a warning inside the keyboard shortcut list modal about the conflict. This should not prevents other shortcuts from working, nor triggers multiples action using a single key combination. Only the last identical keyboard shortcut registered must be available. This matters only if they are available in the same context. Acceptance criteria
|
…d-menu-shortcut-component * pro-3244-command-menu-module: rename fields into commands test visible groups and modals add modals
…odule * feature/keyboard-shortcut: fix lint error in vue component cleanup DRY trailing comma nested areas work properly with initialModal: false
…d-menu-shortcut-component * pro-3244-command-menu-module: fix lint error in vue component cleanup DRY trailing comma nested areas work properly with initialModal: false
…-3247-keyboard-shortcuts-conflicts * pro-3248-apos-command-menu-shortcut-component: check commands after filtering translate command menu remove comment remove todo statement use variable in CSS fix i18n lint error add permission fix lint error in vue component rename fields into commands test visible groups and modals add modals cleanup DRY trailing comma nested areas work properly with initialModal: false
…cuts-conflicts * feature/keyboard-shortcut: handle node 16+ better put 14 back on the list doh use npm 8 with node 14, because tiptap
Base automatically changed from
pro-3248-apos-command-menu-shortcut-component
to
feature/keyboard-shortcut
December 20, 2022 19:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If multiple keyboard shortcuts using the same combination of keys are registered, the system must display a warning inside the keyboard shortcut list modal about the conflict. This should not prevents other shortcuts from working, nor triggers multiples action using a single key combination.
Only the last identical keyboard shortcut registered must be available.
This matters only if they are available in the same context.
What are the specific steps to test this change?
npm link apostropheon testbedWhat kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements: