Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pro 3247 keyboard shortcuts conflicts #3953

Closed

Commits on Nov 4, 2022

  1. Configuration menu
    Copy the full SHA
    a65c0f6 View commit details
    Browse the repository at this point in the history
  2. enable command-menu default

    haroun committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    0f1fafb View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Configuration menu
    Copy the full SHA
    53e1cc4 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'feature/keyboard-shortcut' into pro-3244-command-menu-m…

    …odule
    
    * feature/keyboard-shortcut: (45 commits)
      remove tiptap breaking change and duplicates warnings (#3892)
      eslint
      fix various errata in the update menu
      Try better
      Changelog
      Manage busy wizard status to control actions disabled state
      Add `null` to select fields with a function name as choices (#3924)
      date
      remove TODO
      release 3.31.0
      undo weird change
      aposPlaceholder: true supersedes all field values
      fix advisory message
      do not try to "convert" while aposPlaceholder is still in effect; do not clone unnecessarily; always respect placeholders regardless of field values until aposPlaceholder is cleared
      add widget placeholders feature (#3910)
      release 3.30.0
      changelog, webpack context
      update vue-loader
      refactor addFileGroup method
      response to comments
      ...
    haroun committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    c47809f View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. filter visible items

    haroun committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    5c6e85f View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. validate commands and groups

    haroun committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    2420ba8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd82096 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. test visible commands

    haroun committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    31f51db View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. replace every with some

    haroun committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    dc0bd8e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3fba229 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Configuration menu
    Copy the full SHA
    a3342d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97edffb View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Configuration menu
    Copy the full SHA
    c0cb97c View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Configuration menu
    Copy the full SHA
    583f0ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    29019ec View commit details
    Browse the repository at this point in the history
  3. set shortcuts as computed

    haroun committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    3d4ed96 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. debug meta key

    haroun committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    9c4659e View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. allow to map multiple shortcut to a single action

    map undo/redo
    haroun committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    1a90eea View commit details
    Browse the repository at this point in the history
  2. enable additional shortcuts

    haroun committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    01a87b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. Configuration menu
    Copy the full SHA
    58125b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    307d77c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    08a1e03 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Configuration menu
    Copy the full SHA
    4e5b949 View commit details
    Browse the repository at this point in the history
  2. Disable shortcut commands when focus in rich-text editor

    Anthony Tarlao committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    cba83a5 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'origin/pro-3248-apos-command-menu-short…

    …cut-component' into pro-3248-apos-command-menu-shortcut-component
    Anthony Tarlao committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    20ae63f View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. display manager shortcuts

    haroun committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    43cf7a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4dcc11b View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'origin/pro-3248-apos-command-menu-short…

    …cut-component' into pro-3248-apos-command-menu-shortcut-component
    Anthony Tarlao committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    2158d9b View commit details
    Browse the repository at this point in the history
  4. fix empty commands errors

    haroun committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    5d6a176 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'pro-3248-apos-command-menu-shortcut-component' of githu…

    …b.com:apostrophecms/apostrophe into pro-3248-apos-command-menu-shortcut-component
    
    * 'pro-3248-apos-command-menu-shortcut-component' of github.com:apostrophecms/apostrophe:
      Disable shortcut commands when focus in rich-text editor and inputs
    haroun committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    5f95eb1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    efad61b View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. implement manager shortcuts

    haroun committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    82ed512 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Configuration menu
    Copy the full SHA
    52be0cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    25d11d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Configuration menu
    Copy the full SHA
    dbe6730 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4ba4b08 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7518fb6 View commit details
    Browse the repository at this point in the history
  4. page manager shortcuts

    haroun committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    3d07f4e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    61d199b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    755686f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c08372a View commit details
    Browse the repository at this point in the history
  8. Merge branch 'main' into pro-3244-command-menu-module

    * main: (53 commits)
      fast parking
      chore: prettify a bit & iterate over `Object.keys` instead of `for ... in`
      release 3.33.0
      protect against any possibility of dcad-1191 manifesting in A3
      update changelog
      for easier extension of the rich-text checking and adding all `defaultOptions` to the `activeOptions`
      Publish batch icon (#3944)
      dashed lines magic
      kill the foreign hover on mouseleave, also defensive driving
      Add "publish" batch feature to manager modal (#3939)
      Fixes based on comments
      add more info about PR contribution
      typos
      changelog
      working solution
      better link
      shiny new documentation link for email
      release-3.32.0
      use created, not mounted, to fix captcha
      shorthand css prop, changelog
      ...
    haroun committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    b230753 View commit details
    Browse the repository at this point in the history
  9. get all errors at once

    haroun committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    97c4a72 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Configuration menu
    Copy the full SHA
    d19d3cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4fe777a View commit details
    Browse the repository at this point in the history
  3. Merge branch 'pro-3244-command-menu-module' into pro-3248-apos-comman…

    …d-menu-shortcut-component
    
    * pro-3244-command-menu-module: (56 commits)
      explicit command or group name in test
      compile errors from multiple modules test
      get all errors at once
      fast parking
      chore: prettify a bit & iterate over `Object.keys` instead of `for ... in`
      release 3.33.0
      protect against any possibility of dcad-1191 manifesting in A3
      update changelog
      for easier extension of the rich-text checking and adding all `defaultOptions` to the `activeOptions`
      Publish batch icon (#3944)
      dashed lines magic
      kill the foreign hover on mouseleave, also defensive driving
      Add "publish" batch feature to manager modal (#3939)
      Fixes based on comments
      add more info about PR contribution
      typos
      changelog
      working solution
      better link
      shiny new documentation link for email
      ...
    haroun committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    6d83618 View commit details
    Browse the repository at this point in the history
  4. manager shortcuts

    haroun committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    8e5c732 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'pro-3248-apos-command-menu-shortcut-component' into pro…

    …-3247-keyboard-shortcuts-conflicts
    Anthony Tarlao committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    2ea57cc View commit details
    Browse the repository at this point in the history
  6. add support for then

    haroun committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    3633b75 View commit details
    Browse the repository at this point in the history
  7. fix unique key

    haroun committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    101b78f View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. fix typo

    haroun committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6a48a36 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Notify shortcut conflicts

    Anthony Tarlao committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    02e890b View commit details
    Browse the repository at this point in the history
  2. Merge branch 'pro-3248-apos-command-menu-shortcut-component' into pro…

    …-3247-keyboard-shortcuts-conflicts
    Anthony Tarlao committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    18687a0 View commit details
    Browse the repository at this point in the history
  3. Test on detectShortcutConflict

    Anthony Tarlao committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    344c5c1 View commit details
    Browse the repository at this point in the history
  4. CHANGELOG updated

    Anthony Tarlao committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    6954f5d View commit details
    Browse the repository at this point in the history
  5. add modals

    haroun committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    db9a8b0 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Configuration menu
    Copy the full SHA
    37f33a2 View commit details
    Browse the repository at this point in the history
  2. rename fields into commands

    haroun committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    9330d66 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'pro-3244-command-menu-module' into pro-3248-apos-comman…

    …d-menu-shortcut-component
    
    * pro-3244-command-menu-module:
      rename fields into commands
      test visible groups and modals
      add modals
    haroun committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    8e028c2 View commit details
    Browse the repository at this point in the history
  4. add permission

    haroun committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    322e038 View commit details
    Browse the repository at this point in the history
  5. fix i18n lint error

    haroun committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    ce61fd7 View commit details
    Browse the repository at this point in the history
  6. use variable in CSS

    haroun committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    8f3b6e5 View commit details
    Browse the repository at this point in the history
  7. remove todo statement

    haroun committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    a5be655 View commit details
    Browse the repository at this point in the history
  8. remove comment

    haroun committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3632a41 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. translate command menu

    haroun committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    5b08ba7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de03e8d View commit details
    Browse the repository at this point in the history
  3. Merge branch 'feature/keyboard-shortcut' into pro-3244-command-menu-m…

    …odule
    
    * feature/keyboard-shortcut:
      fix lint error in vue component
      cleanup
      DRY
      trailing comma
      nested areas work properly with initialModal: false
    haroun committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    ce6a90e View commit details
    Browse the repository at this point in the history
  4. Merge branch 'pro-3244-command-menu-module' into pro-3248-apos-comman…

    …d-menu-shortcut-component
    
    * pro-3244-command-menu-module:
      fix lint error in vue component
      cleanup
      DRY
      trailing comma
      nested areas work properly with initialModal: false
    haroun committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    a6199bd View commit details
    Browse the repository at this point in the history
  5. Merge branch 'pro-3248-apos-command-menu-shortcut-component' into pro…

    …-3247-keyboard-shortcuts-conflicts
    
    * pro-3248-apos-command-menu-shortcut-component:
      check commands after filtering
      translate command menu
      remove comment
      remove todo statement
      use variable in CSS
      fix i18n lint error
      add permission
      fix lint error in vue component
      rename fields into commands
      test visible groups and modals
      add modals
      cleanup
      DRY
      trailing comma
      nested areas work properly with initialModal: false
    haroun committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    f4fd884 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. Merge branch 'feature/keyboard-shortcut' into pro-3247-keyboard-short…

    …cuts-conflicts
    
    * feature/keyboard-shortcut:
      handle node 16+ better
      put 14 back on the list doh
      use npm 8 with node 14, because tiptap
    haroun committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    d42beae View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Add req.t translations

    Anthony Tarlao committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    34f31f2 View commit details
    Browse the repository at this point in the history