if chooser is set to limit 1, remove reorder controls. also disable p… #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osition UI for items that dont make sense, ie the first item cant move up any further
|
Does it behave when you move the item so it is no longer first? Not sure we re-render the whole thing in that situation. Asking if the up button comes back or not. |
|
it does |
boutell
approved these changes
Jan 17, 2020
|
ah it does when adding or removing stuff but not reordering stuff, putting this on blocks for the mo' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…osition UI for items that dont make sense, ie the first item cant move up any further
address #1396 and it's comments